Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add task solution #132

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

add task solution #132

wants to merge 4 commits into from

Conversation

D0dgerJ
Copy link

@D0dgerJ D0dgerJ commented Oct 14, 2024

SanyaBratashchuk
SanyaBratashchuk suggested changes Oct 14, 2024
View reviewed changes
Copy link

@SanyaBratashchuk SanyaBratashchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
get rid of horizontal scroll on mobile

volodymyr-soltys97
volodymyr-soltys97 suggested changes Oct 14, 2024
View reviewed changes
Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done!
To improve:

  1. The phone number cannot contain letters
image
  1. The height of the menu should be 100% of the height of the browser window
image

  1. Also, you need to remove scroll when the menu is open The height of the menu should be 100% of the height of the browser window

  2. Fix the mobile version

image

anastasiiavorobiova
anastasiiavorobiova suggested changes Oct 14, 2024
View reviewed changes
Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!
Screenshot 2024-10-14 at 15 38 55
Screenshot 2024-10-14 at 15 40 03
Check the layout for these sections on tablets and mobiles

anastasiiavorobiova
anastasiiavorobiova approved these changes Oct 14, 2024
View reviewed changes
Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anastasiiavorobiova anastasiiavorobiova anastasiiavorobiova approved these changes

@SanyaBratashchuk SanyaBratashchuk Awaiting requested review from SanyaBratashchuk

@volodymyr-soltys97 volodymyr-soltys97 Awaiting requested review from volodymyr-soltys97

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@D0dgerJ @volodymyr-soltys97 @SanyaBratashchuk @anastasiiavorobiova