Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

created Landing page #138

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

created Landing page #138

wants to merge 6 commits into from

Conversation

OlehPhw
Copy link

@OlehPhw OlehPhw commented Nov 20, 2024

etojeDenys
etojeDenys suggested changes Nov 20, 2024
View reviewed changes
Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. looks different
image image
image image
  1. disable page reloading on form submit
  2. menu doesn't work
image
image image

@OlehPhw OlehPhw requested a review from etojeDenys November 21, 2024 09:10
etojeDenys
etojeDenys suggested changes Nov 21, 2024
View reviewed changes
Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sure you deploy your changes

@OlehPhw OlehPhw requested a review from etojeDenys November 21, 2024 09:35
etojeDenys
etojeDenys approved these changes Nov 21, 2024
View reviewed changes
Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good in general, but you don't fix that comment with this text on mobile(it looks different from the mockup)
image

and don't forget to fix page scrolling when the menu is open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etojeDenys etojeDenys etojeDenys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OlehPhw @etojeDenys