-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
first version #1969
base: main
Are you sure you want to change the base?
first version #1969
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job 👍
Let's improve your page
- Fix size for these icons on the desktop
- The images shouldn't overlap each other when hovering
- Remove default blue border when input is focused
- This element should be link with
mailto:
- Fix the background image position
- You need to hide additional phone number on the mobile and tablet versions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like your deploy is broken, please fix it. Don't hesitate to ask for help in fe_chat
Resolve problem by history chat, delete directory parcel-cache and dist |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job, there are a few comments to fix:
- Header should take 100% of viewport height. Please fix it
- it should be possible to hover the number
- Change autocomplete styles for input fields
https://css-tricks.com/snippets/css/change-autocomplete-styles-webkit-browsers/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job 👍
DEMO LINK
some things doesn't added from figma file, like an hover effects for footer link, but added another effect