Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first version #1969

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

first version #1969

wants to merge 4 commits into from

Conversation

NickDevX
Copy link

DEMO LINK

some things doesn't added from figma file, like an hover effects for footer link, but added another effect

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍
Let's improve your page

  1. Fix size for these icons on the desktop
image
  1. The images shouldn't overlap each other when hovering
image
  1. Remove default blue border when input is focused
image
  1. This element should be link with mailto:
image
  1. Fix the background image position
image
  1. You need to hide additional phone number on the mobile and tablet versions
image

Copy link

@vadiimvooo vadiimvooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like your deploy is broken, please fix it. Don't hesitate to ask for help in fe_chat

@NickDevX
Copy link
Author

Resolve problem by history chat, delete directory parcel-cache and dist

@NickDevX NickDevX requested a review from vadiimvooo January 18, 2025 17:36
Copy link

@vadiimvooo vadiimvooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, there are a few comments to fix:

  1. Header should take 100% of viewport height. Please fix it
  2. it should be possible to hover the number
    image
  3. Change autocomplete styles for input fields
    https://css-tricks.com/snippets/css/change-autocomplete-styles-webkit-browsers/

@NickDevX NickDevX requested a review from vadiimvooo January 20, 2025 17:28
Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants