Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

need to adjust the rectangle #5664

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

need to adjust the rectangle #5664

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ae6658e
add task solution
Sahardi Nov 9, 2024
fa96b9c
add changes to html and css code
Sahardi Jan 19, 2025
3c785ea
adjustment of rectangle
Sahardi Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ The page should match the design Pixel Perfect: all the sizes, colors and distan

❗️ Replace `<your_account>` with your Github username and copy the links to `Pull Request` description:

- [DEMO LINK](https://<your_account>.github.io/layout_moyo-header/)
- [TEST REPORT LINK](https://<your_account>.github.io/layout_moyo-header/report/html_report/)
- [DEMO LINK](https://Sahardi.github.io/layout_moyo-header/)
- [TEST REPORT LINK](https://Sahardi.github.io/layout_moyo-header/report/html_report/)

❗️ Copy this `Checklist` to the `Pull Request` description after links, and put `- [x]` before each point after you checked it.

Expand Down
3 changes: 3 additions & 0 deletions src/images/Rectangle 2.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
46 changes: 45 additions & 1 deletion src/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,50 @@
/>
</head>
<body>
<h1>Moyo header</h1>
<header class="container">
<img src="./images/logo.png"
class="img"
alt="moyologo">

<nav class="nav">
<ul class="nav_list">
<div src="./images/Rectangle 2.svg"
class="rect"
alt="line">>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The <div> element should not have a src attribute. If you intend to display an image, use an <img> tag instead.

<ul class="apple is-active"
href="apple.html">APPLE
</ul>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The <ul> element is incorrectly used here. If you intend to create a navigation link, consider using an <li> element within a <ul> or <nav> and wrap the text in an <a> tag with the href attribute.

</div>
<ul class="sams"
href="samsung.html">SAMSUNG
</ul>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to the previous comment, the <ul> element is not appropriate here. Use an <li> element within a <ul> or <nav> and wrap the text in an <a> tag.


<ul class="smart"
href="smartphones.html">SMARTPHONES
</ul>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The <ul> element is incorrectly used for navigation. Replace it with an <li> element and wrap the text in an <a> tag.


<ul class="lapcom"
data-qa="hover"
href="laptops&computers.html">LAPTOPS & COMPUTERS
</ul>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The <ul> element should be replaced with an <li> element for navigation purposes, and the text should be wrapped in an <a> tag.


<ul class="gadg"
href="gadgets.html">GADGETS
</ul>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace the <ul> element with an <li> element and wrap the text in an <a> tag for proper navigation structure.


<ul class="tab"
href="tablets.html">TABLETS
</ul>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The <ul> element is not suitable here. Use an <li> element and wrap the text in an <a> tag for navigation.


<ul class="ph"
href="photo.html">PHOTO
</ul>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace the <ul> element with an <li> element and wrap the text in an <a> tag for proper navigation.


<ul class="vi"
href="video.html">VIDEO
</ul>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The <ul> element should be replaced with an <li> element, and the text should be wrapped in an <a> tag for navigation.

</ul>
</nav>
</header>
</body>
</html>
36 changes: 36 additions & 0 deletions src/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,39 @@
body {
margin: 0;
}

@font-face {
font-family: Roboto;
src: url(https://fonts.google.com/specimen/Roboto);
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The src attribute in the @font-face rule should point to a valid font file URL, such as a .woff, .woff2, or similar file type, rather than a Google Fonts page URL. Consider using the correct URL format provided by Google Fonts for embedding fonts.


.container{
display:flex;
flex-direction: row;
font-family: system-ui, Roboto, sans-serif;
font-size: 12px;
height: 60px;
width: 1024px;
background-color: #fff;
}

.img {
height: 40px;
width: 40px;
margin-top: 10px;
margin-left: 50px;
}

.nav{
display: flex;
justify-content: center;
align-items: center;
}

.nav_list{
display: flex;
}

.rect{
background-position: bottom;
}
Loading