Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Strict typing and fixed schemas for emmet document models #1174

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[WIP] Strict typing and fixed schemas for emmet document models #1174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3df7048
Add pydantic models for pymatgen objects, clean up TaskDoc typing / d…
esoteric-ephemera Jan 17, 2025
6e97455
precommit
esoteric-ephemera Jan 17, 2025
ff50f3c
fix tests
esoteric-ephemera Jan 18, 2025
eca2e4f
precommit
esoteric-ephemera Jan 18, 2025
0bb8574
update api test to reflect gzipped testfile
esoteric-ephemera Jan 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion emmet-api/tests/materials/tasks/test_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import os
from json import load
from monty.io import zopen

from emmet.api.core.settings import MAPISettings
from emmet.api.routes.materials.tasks.utils import (
Expand All @@ -24,7 +25,7 @@ def test_calcs_reversed_to_trajectory():


def test_task_to_entry():
with open(os.path.join(MAPISettings().TEST_FILES, "test_task.json")) as file:
with zopen(os.path.join(MAPISettings().TEST_FILES, "test_task.json.gz")) as file:
doc = load(file)

entry_dict = task_to_entry(doc)
Expand Down
Loading
Loading