-
Notifications
You must be signed in to change notification settings - Fork 875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove explicit declare of package-data #4018
Open
DanielYang59
wants to merge
48
commits into
materialsproject:master
Choose a base branch
from
DanielYang59:package-data
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
48 commits
Select commit
Hold shift + click to select a range
e840571
remove package-data section
DanielYang59 43fe42d
WIP: fix some reason files listed in exclude-package-data is still in…
DanielYang59 06f9836
Merge branch 'master' into package-data
DanielYang59 e868a89
Merge branch 'master' into package-data
DanielYang59 b68f5af
Merge branch 'master' into package-data
DanielYang59 694ccc6
Merge branch 'master' into package-data
DanielYang59 68f4960
Merge branch 'master' into package-data
DanielYang59 634e7c8
Merge branch 'master' into package-data
DanielYang59 967952c
update omitted files for coverage
DanielYang59 c8a3a50
include everything for now
DanielYang59 5414ca5
Merge branch 'master' into package-data
DanielYang59 fca74fe
Merge branch 'master' into package-data
DanielYang59 6faac54
Merge branch 'master' into package-data
DanielYang59 2f36ad0
Merge branch 'master' into package-data
DanielYang59 605df2c
experimented with setuptools-scm, but no luck to exclude file
DanielYang59 47025a6
maybe give setuptools-scm a chance, need really careful check of pack…
DanielYang59 49905f2
fix py.typed placement
DanielYang59 08bf67d
Merge branch 'master' into package-data
DanielYang59 f142b94
Merge branch 'master' into package-data
DanielYang59 73aa493
Merge branch 'master' into package-data
DanielYang59 1cd423a
Merge branch 'master' into package-data
DanielYang59 b2eda5b
Merge branch 'master' into package-data
shyuep bac2e8a
Merge branch 'master' into package-data
DanielYang59 6c4b781
Merge branch 'master' into package-data
DanielYang59 8f1bcc4
encourage google style docstring
DanielYang59 b4388a8
fix internal index
DanielYang59 2c50c00
TEST, test install from sdist
DanielYang59 b1ef965
Revert "TEST, test install from sdist"
DanielYang59 8482fff
revert contributing change
DanielYang59 3a1877b
change default to False
DanielYang59 04b8f3b
Revert "change default to False"
DanielYang59 aa0e4dd
Merge branch 'master' into package-data
DanielYang59 cf3108d
Merge branch 'master' into package-data
DanielYang59 7a2db54
unskip test_pkg
DanielYang59 fb84435
refactor test_pkg
DanielYang59 8ed49b2
add test_source_distribution
DanielYang59 de0da3f
remove bdist build
DanielYang59 7b48912
fix failure in Windows and avoid hard-coded slash
DanielYang59 3b3b040
rename src_dir to avoid confusion
DanielYang59 9909527
simplify file reading for Path obj
DanielYang59 4bdb549
avoid checking SOURCES.txt in sdist
DanielYang59 8f291d8
also check typed file
DanielYang59 937e547
temp save
DanielYang59 75c9917
revert py.typed change
DanielYang59 560565b
Merge branch 'master' into package-data
DanielYang59 31dc284
Merge branch 'master' into package-data
DanielYang59 d6b8e67
Merge branch 'master' into package-data
DanielYang59 159c5c6
Merge branch 'master' into package-data
DanielYang59 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
# Exclude entire directories | ||
prune .github/ | ||
prune dev_scripts/ | ||
prune docs/ | ||
prune examples/ | ||
prune tests/ | ||
|
||
# Exclude individual files | ||
exclude .* \ | ||
ADMIN.md CONTRIBUTING.md SECURITY.md \ | ||
CITATION.cff pdm.lock tasks.py |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would rather accidentally include some useless files than missing some necessary ones, so I should be really careful using wildcard for exclusion.
Is there any hidden file needed (at least no from current distributions)?