Fix py.typed
usage for namespace packages
#4199
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
py.typed
marker file placement to close The currentpy.typed
setup does not seem ideal #3413:py.typed
files, verify the original reported issue is gone (Skipping analyzing "pymatgen.io.vasp.inputs": module is installed, but missing library stubs or py.typed marker [import]
)analysis / ext / io
, are they meant to be namespace packages as well?Looks like some sub-modules (
analysis / ext / io
) are implicit namespace packages as well (no__init__.py
)? i.e.pymatgen
is namespace package, so dopymatgen.ext/pymatgen.analysis/pymatgen.io
. Not sure if this is intended, AFAIK sharing thepymatgen
namespace is sufficient to supportpymatgen-analysis-defects/analysis/diffusion
,pymatgen-io-validation
?Also quote Anthony Sottile:
https://github.com/materialsproject/pymatgen/tree/master/src/pymatgen/ext
https://github.com/materialsproject/pymatgen/tree/master/src/pymatgen/io
https://github.com/materialsproject/pymatgen/tree/master/src/pymatgen/analysis