Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:move input view based on delta to handle all embedding cases #15

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pevensen
Copy link
Contributor

@pevensen pevensen commented Jul 7, 2014

The previous change to adjust for the chat view controller being in a tab view controller does not work if the chat view controller is contained in its own navigation controller (it still shows a blank space the height of the tab bar).

This fix properly moves the input view regardless of how the chat view controller is embedded (i.e. it works with the current demo app with no embedding, it work if the chat view controller is embedded in a tab view controller with or without a navigation controller containing the chat view controller, and it works if the chat view controller is embedded in a navigation view controller).

Sorry I didn't catch this issue with the previous enhancement.

@pevensen
Copy link
Contributor Author

pevensen commented Aug 6, 2014

The message Text Entry position adjustment based on font size and entered text was also not set using global coordinates. I added that to this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant