Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
What type of PR is this?
Which issue(s) this PR fixes:
issue #https://github.com/matrixorigin/MO-Cloud/issues/3490 #https://github.com/matrixorigin/MO-Cloud/issues/3530
#https://github.com/matrixorigin/MO-Cloud/issues/3521 #https://github.com/matrixorigin/MO-Cloud/issues/3512
What this PR does / why we need it:
fix check invalid binds
PR Type
Bug fix, Tests
Description
isRetryError
in thecheckInvalidBinds
method to prevent potential nil pointer dereference.TestRetryValidateService
to include a nil check beforeisRetryError
.TestValidateService
to validate service responses, ensuring correct behavior for both valid and invalid service IDs.Changes walkthrough 📝
lock_table_allocator.go
Add nil check before retry error validation in `checkInvalidBinds`
pkg/lockservice/lock_table_allocator.go
isRetryError
incheckInvalidBinds
method.
rpc_test.go
Enhance service validation tests with additional checks
pkg/lockservice/rpc_test.go
TestRetryValidateService
to include a nil check beforeisRetryError
.TestValidateService
to validate service responses.