Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove tmp buf from table_scan #16969

Merged

Conversation

ouyuanning
Copy link
Contributor

What type of PR is this?

  • API-change
  • BUG
  • Improvement
  • Documentation
  • Feature
  • Test and CI
  • Code Refactoring

Which issue(s) this PR fixes:

issue #14940

What this PR does / why we need it:

这个原来是因为有时reader返回的数据量较小,使得可以上范围锁的变成上点锁。容易造成点锁数量较大时加的。

现在一个是没有范围锁了,另外当点锁太大会转表锁,这部分逻辑应该没有必要存在了,徒增复杂度。

@ouyuanning ouyuanning requested a review from m-schen as a code owner June 18, 2024 08:33
@matrix-meow matrix-meow added the size/S Denotes a PR that changes [10,99] lines label Jun 18, 2024
@mergify mergify bot added the kind/refactor Code refactor label Jun 18, 2024
@mergify mergify bot merged commit b2848a0 into matrixorigin:main Jun 18, 2024
17 of 18 checks passed
@ouyuanning ouyuanning deleted the refactor-table_scan-remote-temp-buf branch August 5, 2024 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/refactor Code refactor size/S Denotes a PR that changes [10,99] lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants