sync to 1.2: fix Size() duplicate counting rows size.
#17147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gouhongshen
changed the title
Size() duplicate counting rows size.Size() duplicate counting rows size.
XuPeng-SH
approved these changes
Jun 25, 2024
aressu1985
approved these changes
Jun 25, 2024
sukki37
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue(s) this PR fixes:
issue ##17024
What this PR does / why we need it:
之前统计 partition state 里面的 rows 时，使用的是 row.Batch 的地址昨晚去重的手段，绝大多数情况下没有问题，但一条记录也可能会重复推到 CN，不属于同一个 logtail, 自然也不属于同一个 batch，所以就做不到去重的目的。现在使用 rowid 去重。