Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC-7500: Invite People page needs animated GIFs for mobile app workflows #7501

Merged
merged 13 commits into from
Oct 22, 2024
Merged

DOC-7500: Invite People page needs animated GIFs for mobile app workflows #7501

merged 13 commits into from
Oct 22, 2024

Conversation

Rutam21
Copy link
Contributor

@Rutam21 Rutam21 commented Oct 17, 2024

Summary

This PR adds visual workflows for the Mattermost mobile app tabs on the Invite People page

Ticket Link

Fixes #7500

  • This PR follows Mattermost Contributing Guidelines.

@mattermost-build
Copy link
Contributor

Hello @Rutam21,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@Rutam21
Copy link
Contributor Author

Rutam21 commented Oct 17, 2024

@cwarnermm Please review and suggest changes, if any. Thanks.

@cwarnermm cwarnermm self-assigned this Oct 18, 2024
@cwarnermm cwarnermm added 2: Editor Review Requires review by an editor preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories labels Oct 18, 2024
@github-actions GitHub Actions
Copy link

Newest code from Rutam21 has been published to preview environment for Git SHA 2e5a5d8

cwarnermm
cwarnermm requested changes Oct 18, 2024
View reviewed changes
source/collaborate/invite-people.rst Show resolved Hide resolved
source/collaborate/invite-people.rst Outdated Show resolved Hide resolved
source/collaborate/invite-people.rst Outdated Show resolved Hide resolved
source/collaborate/invite-people.rst Outdated Show resolved Hide resolved
source/collaborate/invite-people.rst Outdated Show resolved Hide resolved
source/collaborate/invite-people.rst Outdated Show resolved Hide resolved
source/collaborate/invite-people.rst Outdated Show resolved Hide resolved
@Rutam21
Copy link
Contributor Author

Rutam21 commented Oct 18, 2024

@cwarnermm All the requested changes have been done. Please review. Thanks.

@cwarnermm cwarnermm added preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories and removed preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories labels Oct 18, 2024
@github-actions GitHub Actions
Copy link

Newest code from Rutam21 has been published to preview environment for Git SHA 3a76d2f

@cwarnermm cwarnermm added preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories and removed preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories labels Oct 21, 2024
@github-actions GitHub Actions
Copy link

Newest code from Rutam21 has been published to preview environment for Git SHA 8c167a1

cwarnermm
cwarnermm reviewed Oct 21, 2024
View reviewed changes
source/collaborate/invite-people.rst Outdated Show resolved Hide resolved
source/collaborate/invite-people.rst Outdated Show resolved Hide resolved
source/collaborate/invite-people.rst Outdated Show resolved Hide resolved
source/collaborate/invite-people.rst Outdated Show resolved Hide resolved
source/collaborate/invite-people.rst Outdated Show resolved Hide resolved
@cwarnermm cwarnermm added preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories and removed preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories labels Oct 22, 2024
@github-actions GitHub Actions
Copy link

Newest code from Rutam21 has been published to preview environment for Git SHA 74c0346

@cwarnermm cwarnermm self-requested a review October 22, 2024 14:00
cwarnermm
cwarnermm reviewed Oct 22, 2024
View reviewed changes
Copy link
Member

@cwarnermm cwarnermm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Rutam21!!

@cwarnermm cwarnermm added QA-wanted and removed 2: Editor Review Requires review by an editor labels Oct 22, 2024
@cwarnermm cwarnermm self-requested a review October 22, 2024 14:01
@varghesejose2020
Copy link
Contributor

@lindy65 please assign me

@lindy65
Copy link
Contributor

lindy65 commented Oct 22, 2024

Assigned to you for testing @varghesejose2020 - you can check the preview environment here

@varghesejose2020
Copy link
Contributor

The changes in this PR have been tested in the preview environment and changes are working as expected. Adding screenshots for confirmation

Send a direct invite

IMG_20241022_215841

Send a Team invite

IMG_20241022_215809
cc: @lindy65

@lindy65 lindy65 added QA-done QA review is complete and removed QA-wanted labels Oct 22, 2024
@lindy65
Copy link
Contributor

lindy65 commented Oct 22, 2024

Thanks for testing @varghesejose2020 - counted towards Hacktoberfest

cc @cwarnermm

@cwarnermm cwarnermm added 3: Reviews Complete All reviewers have approved the pull request and removed preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories labels Oct 22, 2024
@cwarnermm cwarnermm merged commit 76f9bdc into mattermost:master Oct 22, 2024
6 checks passed
@Rutam21 Rutam21 deleted the DOC-7500 branch November 1, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwarnermm cwarnermm cwarnermm approved these changes

Assignees

@cwarnermm cwarnermm

Labels
3: Reviews Complete All reviewers have approved the pull request Contributor Hacktoberfest null QA-done QA review is complete
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invite People page needs animated GIFs for mobile app workflows
5 participants
@Rutam21 @mattermost-build @varghesejose2020 @lindy65 @cwarnermm