Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC-7531: Join and leave channels page needs animated GIFs for mobile app workflows #7532

Merged
merged 2 commits into from
Nov 1, 2024

Conversation

Rutam21
Copy link
Contributor

@Rutam21 Rutam21 commented Oct 31, 2024

Summary

This PR adds visual workflows for the Mattermost mobile app tab on the Join and leave channels page

Ticket Link

Fixes #7531

  • This PR follows Mattermost Contributing Guidelines.

@mattermost-build
Copy link
Contributor

Hello @Rutam21,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@Rutam21
Copy link
Contributor Author

Rutam21 commented Oct 31, 2024

@cwarnermm Please review and suggest changes, if any. Thanks.

@lindy65 Please add this to my queue for QA Testing once the reviews are complete. Thank you.

@lindy65
Copy link
Contributor

lindy65 commented Nov 1, 2024

Assigned to you for testing @Rutam21 - will still count towards Hacktoberfest as it was before end of day on 31 Oct

@lindy65 lindy65 added the preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories label Nov 1, 2024
Copy link

github-actions bot commented Nov 1, 2024

Newest code from Rutam21 has been published to preview environment for Git SHA 0bda9ed

@Rutam21
Copy link
Contributor Author

Rutam21 commented Nov 1, 2024

The changes are tested in the preview environment and they reflect properly.

  • The Join and leave channels page has now 6 new workflow images under the mobile tab for visual learners.

Please refer to the screenshots below as a confirmation.

Current Docs Page [Join and leave channels]

Join a channel Section

Screenshot 2024-11-01 141844

Leave a channel section

Screenshot 2024-11-01 141859

Preview Environment Page

Join a channel Section

Step 1

Screenshot 2024-11-01 142048

Step 2

Screenshot 2024-11-01 142104

Step 3

Screenshot 2024-11-01 142120

Leave a channel section

Step 1

Screenshot 2024-11-01 142321

Step 2

Screenshot 2024-11-01 142336

Step 3

Screenshot 2024-11-01 142350

Step 4

Screenshot 2024-11-01 142405

[ Awaiting final review from @cwarnermm ]

cc: @lindy65

@lindy65
Copy link
Contributor

lindy65 commented Nov 1, 2024

Thanks for testing @Rutam21 - counted towards Hacktoberfest

Copy link
Member

@cwarnermm cwarnermm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Rutam21!

@cwarnermm cwarnermm added 3: Reviews Complete All reviewers have approved the pull request QA-done QA review is complete and removed preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories labels Nov 1, 2024
@cwarnermm cwarnermm merged commit b82a9a3 into mattermost:master Nov 1, 2024
4 checks passed
@Rutam21 Rutam21 deleted the DOC-7531 branch November 4, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: Reviews Complete All reviewers have approved the pull request Contributor Hacktoberfest null QA-done QA review is complete
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Join and leave channels page needs animated GIFs for mobile app workflows
4 participants