Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC-7539: Manage channel bookmarks page needs animated GIFs for mobile app workflows #7547

Merged
merged 3 commits into from
Nov 6, 2024
Merged

DOC-7539: Manage channel bookmarks page needs animated GIFs for mobile app workflows #7547

merged 3 commits into from
Nov 6, 2024

Conversation

Rutam21
Copy link
Contributor

@Rutam21 Rutam21 commented Nov 4, 2024

Summary

This PR adds visual workflows for the Mattermost mobile app tab on the Manage channel bookmarks page.

Ticket Link

Fixes #7539

  • This PR follows Mattermost Contributing Guidelines.
  • The changes are tested in a local docs build.

@mattermost-build
Copy link
Contributor

Hello @Rutam21,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@Rutam21
Copy link
Contributor Author

Rutam21 commented Nov 4, 2024

@cwarnermm Please review and suggest changes, if any. Thanks.

@lindy65 Please add this to my queue for QA Testing, if needed. Thank you.

@lindy65 lindy65 requested a review from cwarnermm November 5, 2024 06:39
@lindy65 lindy65 added 2: Editor Review Requires review by an editor preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories labels Nov 5, 2024
@lindy65
Copy link
Contributor

lindy65 commented Nov 5, 2024

Assigned you for testing @Rutam21 👍

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 5, 2024

Newest code from Rutam21 has been published to preview environment for Git SHA edd686c

@cwarnermm
Copy link
Member

@Rutam21 - Would you be able to crop the mobile images in step 4 where there's considerable empty whitespace? Here's an example:
Screenshot 2024-11-05 at 8 57 50 AM

Really loving the animated captures!

@Rutam21
Copy link
Contributor Author

Rutam21 commented Nov 5, 2024 •
edited
Loading

Sure @cwarnermm , consider it done. I will push a new commit for that. And, thanks. I thought GIFs would serve the purpose better.

@Rutam21
Copy link
Contributor Author

Rutam21 commented Nov 5, 2024

@cwarnermm I have added the cropped images.

cwarnermm
cwarnermm approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@cwarnermm cwarnermm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Rutam21!

@cwarnermm cwarnermm added 3: Reviews Complete All reviewers have approved the pull request and removed 2: Editor Review Requires review by an editor preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories labels Nov 6, 2024
@cwarnermm cwarnermm merged commit c285706 into mattermost:master Nov 6, 2024
4 checks passed
@Rutam21 Rutam21 deleted the DOC-7539 branch November 6, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwarnermm cwarnermm cwarnermm approved these changes

Assignees

@Rutam21 Rutam21

Labels
3: Reviews Complete All reviewers have approved the pull request Contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Manage channel bookmarks page needs animated GIFs for mobile app workflows
4 participants
@Rutam21 @mattermost-build @lindy65 @cwarnermm