Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mmctl export create docs with additional options #7673

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

wetneb
Copy link
Contributor

@wetneb wetneb commented Dec 26, 2024

Summary

This adds a couple of new options to the mmctl export create command:

This PR should only be merged once mattermost/mattermost#29406 is.

Ticket Link

https://mattermost.atlassian.net/browse/MM-61997

This adds a couple of new options to the `mmctl export create` command.
@mattermost-build
Copy link
Contributor

Hello @wetneb,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@mattermost-build
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

@cwarnermm
Copy link
Member

cwarnermm commented Jan 6, 2025

Thank you, @wetneb! Are you open to splitting this PR into two PRs? One PR would contain the missing options, and the other would contain the new option tied to mattermost/mattermost#29406. This would allow us to merge the missing changes right away.

@cwarnermm cwarnermm added Awaiting Submitter Action Blocked on the author and removed Lifecycle/1:stale labels Jan 6, 2025
@wetneb
Copy link
Contributor Author

wetneb commented Jan 7, 2025

I only added the existing options in passing and splitting this in two PRs would likely generate a merge conflict later on since they touch the same area, so I am not so motivated to go down that route. I hope you understand.

@cwarnermm cwarnermm added 2: Editor Review Requires review by an editor Do Not Merge/Awaiting Next Release To be merged with the next release (e.g. API documentation updates) and removed Awaiting Submitter Action Blocked on the author labels Jan 7, 2025
@cwarnermm cwarnermm self-requested a review January 7, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2: Editor Review Requires review by an editor Contributor Do Not Merge/Awaiting Next Release To be merged with the next release (e.g. API documentation updates)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants