Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict external data access #130

Merged
merged 3 commits into from
Feb 1, 2024
Merged

Restrict external data access #130

merged 3 commits into from
Feb 1, 2024

Conversation

crspeller
Copy link
Member

Restricts external data access to only when the AI bot is responding to a DM.
External data access is:

  • Fetching posts from out of channel.
  • Fetching data from GitHub
  • Fetching user profile data.

The only exception is user profile data is fetched when SAML or LDAP is enabled for the fetched user and all fields are controlled by LDAP or SAML.

@crspeller crspeller requested a review from jupenur February 1, 2024 00:51
server/ai/conversation.go Show resolved Hide resolved
server/built_in_tools.go Outdated Show resolved Hide resolved
@crspeller crspeller requested a review from jupenur February 1, 2024 16:11
Copy link
Member

@jupenur jupenur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the issue concerning DMs I shared in-thread, LGTM.

@crspeller crspeller merged commit dbe0e62 into master Feb 1, 2024
4 checks passed
@crspeller crspeller deleted the resrict-external-data branch February 1, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants