[MM-1121]: Fix epic selector not displaying options if field is renamed in Jira #1134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing options if epic field is renamed in jira project configuration
Kshitij-Katiyar
added
2: Dev Review
raghavaggarwal2308
requested changes
Dec 22, 2024
Comment on lines
+57
to
+59
| if (epicNameTypeId) { | ||
| break; | ||
| } |
There was a problem hiding this comment.
This will always be false. I think we can remove this
Comment on lines
+89
to
+91
| if (epicNameTypeId) { | ||
| break; | ||
| } |
There was a problem hiding this comment.
Never true, can be removed
Comment on lines
+80
to
+88
| for (const project of this.props.issueMetadata.projects) { | ||
| for (const issueType of project.issuetypes) { | ||
| epicNameTypeId = Object.keys(issueType.fields).find((key) => isEpicNameField(issueType.fields[key])); | ||
| if (epicNameTypeId) { | ||
| epicIssueTypeId = issueType.id; | ||
| projectKey = project.key; | ||
| break; | ||
| } | ||
| } |
There was a problem hiding this comment.
Can create a util for this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Create Issuemodal had a bug: if theEpicfield in a Jira project was renamed to anything other thanEpic, the dropdown for selecting Jira epics displayed no options.Epic, and then checks if the filtered field matches the Epic field schema before fetching all epics from the project.Epic. This PR removes the name-based check and instead relies exclusively on the field schema to identify the Epic field.Ticket Link
Fixes #1121
What to test