Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command to connect user account to MS Teams #100

Merged
merged 3 commits into from
Jul 11, 2024
Merged

Conversation

ayusht2810
Copy link
Contributor

Summary

  • Added command to connect user account to MS Teams
  • Updated help command

Ticket Link

Fixes #66

What to test?

  • Run the slash command /mstmeetings connect
  • Check if user is able to connect by clicking on the provided link
  • Run the slash command /mstmeetings connect again after connecting, the user should get the ephemeral post User already connected to MS Teams Meetings

Checklist

  • Completed dev testing
  • make test Ran test cases and ensured they are passing
  • make check-style Ran style check and ensured both webapp and server pass the checks

@ayusht2810 ayusht2810 requested a review from larkox as a code owner April 19, 2024 10:56
@ayusht2810 ayusht2810 requested a review from mickmister April 19, 2024 10:56
@ayusht2810 ayusht2810 self-assigned this Apr 19, 2024
@ayusht2810 ayusht2810 added the 2: Dev Review Requires review by a core committer label Apr 19, 2024
Comment on lines -28 to -29
client *pluginapi.Client

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose this isn't used anywhere?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

server/command.go Outdated Show resolved Hide resolved
@mickmister mickmister added the 3: QA Review Requires review by a QA tester label Apr 25, 2024
Copy link

@AayushChaudhary0001 AayushChaudhary0001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been tested for the following scenarios:

  • Check the newly added command to connect user account to MS Teams
  • Check the updated help command

The PR was working fine for both the conditions. LGTM. Approved

@ayusht2810 ayusht2810 merged commit e78f21c into master Jul 11, 2024
3 checks passed
@ayusht2810 ayusht2810 deleted the fix-issue-66 branch July 11, 2024 09:35
@raghavaggarwal2308 raghavaggarwal2308 added this to the v2.2.0 milestone Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There Should be a separate command for Connect.
5 participants