-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add command to connect user account to MS Teams #100
Conversation
client *pluginapi.Client | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose this isn't used anywhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR has been tested for the following scenarios:
- Check the newly added command to connect user account to MS Teams
- Check the updated help command
The PR was working fine for both the conditions. LGTM. Approved
Summary
Ticket Link
Fixes #66
What to test?
/mstmeetings connect
/mstmeetings connect
again after connecting, the user should get the ephemeral postUser already connected to MS Teams Meetings
Checklist
make test
Ran test cases and ensured they are passingmake check-style
Ran style check and ensured both webapp and server pass the checks