Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MM-57194]: Marked confidential settings as secret #131

Merged
merged 2 commits into from
Oct 9, 2024
Merged

[MM-57194]: Marked confidential settings as secret #131

merged 2 commits into from
Oct 9, 2024

Conversation

Kshitij-Katiyar
Copy link
Contributor

Summary

Marked confidential settings as secret

Screenshots

Existing

Screenshot from 2024-09-20 21-03-05

Updated

Screenshot from 2024-09-20 21-00-22

@hanzei hanzei added the 2: Dev Review Requires review by a core committer label Sep 20, 2024
hanzei
hanzei reviewed Sep 20, 2024
View reviewed changes
plugin.json Show resolved Hide resolved
@raghavaggarwal2308 raghavaggarwal2308 added the 3: QA Review Requires review by a QA tester label Sep 25, 2024
AayushChaudhary0001
AayushChaudhary0001 approved these changes Oct 1, 2024
View reviewed changes
Copy link

@AayushChaudhary0001 AayushChaudhary0001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been tested for client secret and rest encryption key which get encrypted in the plugin configs, LGTM. Approved.

@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Oct 1, 2024
@raghavaggarwal2308 raghavaggarwal2308 merged commit 9d41ca5 into master Oct 9, 2024
3 checks passed
@raghavaggarwal2308 raghavaggarwal2308 deleted the MM-57194_support-packet_plugin-secrets branch October 9, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AayushChaudhary0001 AayushChaudhary0001 AayushChaudhary0001 approved these changes

@raghavaggarwal2308 raghavaggarwal2308 raghavaggarwal2308 approved these changes

@hanzei hanzei hanzei approved these changes

@wiggin77 wiggin77 Awaiting requested review from wiggin77

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Kshitij-Katiyar @hanzei @raghavaggarwal2308 @AayushChaudhary0001