[MM-823]: Added testcase for post.go #138
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eams-meetings into MM-823
…eams-meetings into MM-823
…lugin-msteams-meetings into MM-823
…lugin-msteams-meetings into MM-823
wiggin77
requested changes
Dec 10, 2024
| api.On("HasPermissionToChannel", "testUserID", "testChannelID", model.PermissionCreatePost).Return(true) | ||
| api.On("GetChannel", "testChannelID").Return(&model.Channel{Id: "testChannelID", Type: model.ChannelTypeDirect}, nil) | ||
| api.On("GetChannelMembers", "testChannelID", 0, 100).Return(model.ChannelMembers{}, nil) | ||
| api.On("CreatePost", mock.Anything).Return(nil, &model.AppError{Message: "error creating the post"}) |
There was a problem hiding this comment.
Let's stay typesafe for these tests.
mockPost := mock.AnythingOfType("*model.Post")then
api.On("CreatePost", mockPost).Return(nil, &model.AppError{Message: "error creating the post"})Do this for all instances.
There was a problem hiding this comment.
@Kshitij-Katiyar I'm still seeing mock.Anything in a number of places. Can you make these type-safe?
wiggin77
reviewed
Jan 9, 2025
wiggin77
requested changes
Jan 9, 2025
| api.On("HasPermissionToChannel", "testUserID", "testChannelID", model.PermissionCreatePost).Return(true) | ||
| api.On("GetChannel", "testChannelID").Return(&model.Channel{Id: "testChannelID", Type: model.ChannelTypeDirect}, nil) | ||
| api.On("GetChannelMembers", "testChannelID", 0, 100).Return(model.ChannelMembers{}, nil) | ||
| api.On("CreatePost", mock.Anything).Return(nil, &model.AppError{Message: "error creating the post"}) |
There was a problem hiding this comment.
@Kshitij-Katiyar I'm still seeing mock.Anything in a number of places. Can you make these type-safe?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added testcase for server/post.go