code simplification to remove the children_only parameter #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chrispy <[email protected]>
chrispy-snps
force-pushed
the
chrispy/remove-children-only-parameter
branch
from
57f5250 to
1c27253
Compare
AlexVonB
approved these changes
Jan 2, 2025
Comment on lines
+173
to
+174
| # apply this tag's final conversion function | ||
| # (BeautifulSoup objects have a name of "[document]" and will not apply one) |
There was a problem hiding this comment.
Maybe the comment would be clearer for future reference if it read:
BeautifulSoup's special objects (e.g. the root object) have special names (like
[document]) and do not match anyconvert_*functions. These objects therefore get skipped automatically by the next part.
There was a problem hiding this comment.
I'm glad you mentioned this! If this suggestion in #136 is implemented, then indeed we could support final conversion functions on BeautifulSoup objects! This could be useful for inserting YAML metadata, or auto-applying a final cleanup via regex, and other fun things like that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a minor code change to remove the
children_onlyparameter of theprocess_tag()function.In actually, it already wasn't needed; the existing code would not find a
convert_[document]()function and thus would apply no final formatting function anyway. This just makes the intended code path forBeautifulSoupobjects a bit clearer in the comments.