Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channel search API #26

Merged
merged 7 commits into from
Jul 31, 2023
Merged

Channel search API #26

merged 7 commits into from
Jul 31, 2023

Conversation

otzy007
Copy link
Contributor

@otzy007 otzy007 commented Nov 17, 2020

No description provided.

@AlexWayfer
Copy link
Collaborator

AlexWayfer commented Nov 19, 2020

I'd like to see a tests for it.

We can wait for a large update from #22, maybe then more tests for existing end-points from me.

BTW, thank you for your contribution.

@mauricew
Copy link
Owner

Thanks for looking at this, I'll put together a list of other endpoints added this year like #6.
There's also just enough different to warrant a new object type like a ChannelSearchResult of some sort.

To not get confused by other searches.
It's channels, not users.

But Twitch has weird different fields for `Get Channel` and `Search Channels`.

Maybe we should have different types (classes)?

For now I don't know how to name them.
@AlexWayfer
Copy link
Collaborator

So, I've updated your branch, and practically remade all of your original code lines. 😅

Different method name, different type…

And specs, just as I wanted.

There's also just enough different to warrant a new object type like a ChannelSearchResult of some sort.

Yeah, I was thinking about this, but haven't came to anything reasonable, we have no similar types in the current version, also endpoint says "it's channels" and some fields are similar, so I've just added more attributes. Obviously, some of them will be empty for Get Channel endpoint, others — for Search Channels. We can change it later.

@AlexWayfer AlexWayfer merged commit 6ea1d90 into mauricew:master Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants