JSON generator #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e refactoring for styling, removing some MBARI specific code, and replacing loggins with the PbpLogger class
…e styling abd remove MBARI/MARS specific code
Closed
|
@danellecline Can you please re-sync your branch? I pulled it and then noted it is behind a few commits in "main". |
carueda
approved these changes
Mar 2, 2024
| msg = f'Could not get account number from AWS. Check your config.ini file. ' \ | ||
| f'Account number is not set in the config.ini file and AWS credentials are not configured.' | ||
| print(msg) | ||
| return None |
There was a problem hiding this comment.
Can you change the return type to accommodate possible None ?
|
|
||
| @pytest.mark.skipif(not AWS_AVAILABLE, | ||
| reason="This test is excluded because it requires a valid AWS account") | ||
| def test_soundtrap_json_generator(): |
There was a problem hiding this comment.
This test is failing for me locally. Though I do have stuff under my ~/.aws perhaps my credentials have expired. To move on quickly, I renamed that dir to something else and now this test is skipped (which is good).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new feature to generate JSON metadata from Soundtrap, IcListen, and NRS audio files.
Some examples:
NRS
python src/main_json_generator.py --json-base-dir=test/json/nrs --output=output --uri=gs://noaa-passive-bioacoustic/nrs/audio/11/nrs_11_2019-2021/audio --prefix=NRS11 --start=20191024 --end=20191101 --recorder=NRSSOUNDTRAP
python src/main_json_generator.py --json-base-dir=test/json/soundtrap --output=output --uri=s3://pacific-sound-ch01 --prefix=7000 --start=20230718 --end=20230719 --recorder=SOUNDTRAPICLISTEN
python src/main_json_generator.py --json-base-dir=test/json/iclisten --output=output --uri=s3://pacific-sound-256khz --prefix=MARS --start=20230718 --end=20230719 --recorder=ICLISTEN