Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Right to Left languages #9682

Open
mrjones-plip opened this issue Dec 3, 2024 · 5 comments
Open

Add support for Right to Left languages #9682

mrjones-plip opened this issue Dec 3, 2024 · 5 comments
Assignees
Labels
Type: Technical issue Improve something that users won't notice

Comments

@mrjones-plip
Copy link
Contributor

Describe the issue
Currently CHT Core assumes all languages are left to right (English, French, etc.).

Describe the improvement you'd like
Support languages that are right to left (RTL) like Arabic

@mrjones-plip mrjones-plip added the Type: Technical issue Improve something that users won't notice label Dec 3, 2024
@mrjones-plip
Copy link
Contributor Author

Related forum post

@andrablaj
Copy link
Member

@garethbowen I copied your notes from this document to keep track of your first findings publicly.

Glossary

RTL: Right To Left
RHS: Right Hand Side
LHS: Left Hand Side

General text

Google translate was used to check that the character sets are supported, and manually added dir="rtl" to the HTML to test the right alignment.

Image

Navigation

The new "material" navigation coming soon will feature a drawer sliding out from the LHS.

Image

Layout of the large screen app

The app currently shows the list on the LHS and the detail on the RHS.

Image

Form navigation

Buttons are right aligned.

Image

Filters

Filters are on the RHS

Image

Dates

Calendars and dates are in the Gregorian calendar.
Image

@andrablaj
Copy link
Member

Additionally, Arabic translations were merged via #9683 and should be available in 4.16.

@andrablaj
Copy link
Member

Notes after talking with @latin-panda:

  • Ensure RTL works for both old and new designs.
  • If we decide to support RTL only for the new design (> 4.12), ensure the old design is not broken by the RTL implementation.

@dianabarsan
Copy link
Member

I've made some progress on this in a branch: #9727

Image
Image
Image
Image
Image
Image
ImageImage

Calendars and report filters still need updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Technical issue Improve something that users won't notice
Projects
Status: In Progress
Development

No branches or pull requests

3 participants