Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a warning for redstone conditions not being met #8262

Open
wants to merge 3 commits into
base: 1.21.x
Choose a base branch
from
Open

Add a warning for redstone conditions not being met #8262

wants to merge 3 commits into from

Conversation

bukowski912
Copy link

@bukowski912 bukowski912 commented Nov 22, 2024 •
edited
Loading

Changes proposed in this pull request:

  • Make GuiInsetElement able to track warnings through a supplier
  • Use a blended warning overlay for GuiInsetElement during a warning
  • Track several activation warnings (based on control type) under GuiRedstoneControlTab
  • Monitor redstone activation state of TileEntityMekanism

@bukowski912
Copy link
Author

bukowski912 commented Nov 22, 2024 •
edited
Loading

Whups, I pushed a cache file. Is there a reason why it isn't in the .gitignore? I'll leave it for now - if this is a mistake, let me know and I will fix it right away. It seems to be already in the repository, at least on my end.

@bukowski912 bukowski912 reopened this Nov 22, 2024
@bukowski912
Copy link
Author

I hate GitHub mobile.

@pupnewfster
Copy link
Member

The cache file is so that you don't have to rewrite all the files to disk when you first checkout and run datagen.

@bukowski912 bukowski912 changed the title Add a warning for machine inactivity due to redstone control Add a warning for redstone conditions not being met Nov 23, 2024
@bukowski912
Copy link
Author

Note that the special blending technique used for the warning overlay may have performance drawbacks, especially in light of previous optimization (e.g. 609b030). In addition, I renamed GuiSideHolder#draw() to drawHolder() as I thought that was much clearer. Let me know if that was an overstep.

@thiakil
Copy link
Member

thiakil commented Dec 20, 2024

In addition, I renamed GuiSideHolder#draw() to drawHolder() as I thought that was much clearer. Let me know if that was an overstep.

I'd rather that be in a separate PR, just to avoid the noise it creates in the diffs

@bukowski912
Add a warning for redstone conditions not being met
e281bba 
- Make GuiInsetElement able to track warnings through a supplier
- Use a separate texture for GuiInsetElement during a warning
- Track the activation warning under GuiRedstoneControlTab
- Add the corresponding lang entry to MekanismLangProvider
- Synchronize activation (redstone) state of TileEntityMekanism
@bukowski912
Properly blend the slot-holder warning overlay & fixup GuiSlotHolder
118c6d3
@bukowski912
Create warnings for redstone activation based on control type
19b20f9
@bukowski912 bukowski912 force-pushed the 1.21.x branch 2 times, most recently from 8eb4cf8 to 19b20f9 Compare December 27, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thiakil thiakil thiakil left review comments

@pupnewfster pupnewfster Awaiting requested review from pupnewfster

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bukowski912 @pupnewfster @thiakil