Replace deprecated ppx_core with ppxlib #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fix works for me. |
|
I'm not able to upgrade to ocaml 4.08 with sqlexpr installed despite this patch. I'm not familiar with opam packaging or ppx but I'm under the impression the issue is that the dependencies in the .opam file(s) are not changed by this PR. |
|
Looking at this again, that comment from me is wrong. That being said, src/OMakefile is not updated by this PR and probably needs the same change. And I think the opam issue is rather that opam keeps the same dependencies even though the pin should change them. |
|
OK, this was caused by opam itself and upgrading it from 2.0.0 to 2.0.5 fixed my issue. edit: that and/or not pinning all the packages of the repo; sorry for the noise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to fix issue #40.