Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly discard inbound HttpContent when connection cancels before readComplete #11496

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

yawkat
Copy link
Member

@yawkat yawkat commented Jan 8, 2025

When a connection is closed before readComplete is called, OptimisticBufferingInboundHandler would not release the input buffer correctly.

Discovered by fuzzing with EmbeddedChannel. I'm not sure if this can happen with a non-embedded channel, but better safe than sorry. A test is not feasible, detection relies on finding dangling buffers, which the test suite is too noisy for.

…eadComplete

When a connection is closed before readComplete is called, OptimisticBufferingInboundHandler would not release the input buffer correctly.

Discovered by fuzzing with EmbeddedChannel. I'm not sure if this can happen with a non-embedded channel, but better safe than sorry. A test is not feasible, detection relies on finding dangling buffers, which the test suite is too noisy for.
@yawkat yawkat added the type: bug Something isn't working label Jan 8, 2025
@yawkat yawkat added this to the 4.8.0 milestone Jan 8, 2025
@graemerocher graemerocher merged commit 7fdb21d into 4.8.x Jan 8, 2025
22 checks passed
@graemerocher graemerocher deleted the release-inbound branch January 8, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants