Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generalize deepspeed linear and implement it for non cuda systems #6932

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

generalize deepspeed linear and implement it for non cuda systems #6932

wants to merge 3 commits into from

Conversation

oelayan7
Copy link
Contributor

@oelayan7 oelayan7 commented Jan 8, 2025

No description provided.

loadams
loadams reviewed Jan 8, 2025
View reviewed changes
op_builder/fp_quantizer.py Outdated Show resolved Hide resolved
@oelayan7
Copy link
Contributor Author

oelayan7 commented Jan 9, 2025

@loadams I think the failure in cpu-torch isn't related to the changes, as it passed yesterday (in the first commit)

Thanks in advance

@loadams
Copy link
Contributor

loadams commented Jan 9, 2025

@loadams I think the failure in cpu-torch isn't related to the changes, as it passed yesterday (in the first commit)

Thanks in advance

@oelayan7 - yes, I've not yet debugged this failure since it only occurs on some of the GitHub provided runners, but it is intermittent and I'll re-run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loadams loadams loadams left review comments

@tohtana tohtana Awaiting requested review from tohtana tohtana is a code owner

@tjruwase tjruwase Awaiting requested review from tjruwase tjruwase is a code owner

@jomayeri jomayeri Awaiting requested review from jomayeri jomayeri is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oelayan7 @loadams