refactor(tree): move global and rename effects to the delta root #23484
+684
−759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: dds
| */ | ||
| readonly global?: readonly DetachedNodeChanges[]; | ||
| /** | ||
| * Detached whose associated ID needs to be updated. |
There was a problem hiding this comment.
Suggested change
| * Detached whose associated ID needs to be updated. | |
| * Detached roots whose associated ID needs to be updated. |
Comment on lines
200
to
202
| export type ToDelta = ( | ||
| child: NodeId, | ||
| ) => [DeltaFieldMap, DeltaDetachedNodeChanges[], DeltaDetachedNodeRename[]] | undefined; |
There was a problem hiding this comment.
Is there a reason this contract needs to change? (See the second paragraph in https://dev.azure.com/fluidframework/internal/_workitems/edit/13504)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change moves the global and renames effects out of the delta field changes and into the delta root object.