Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate Qiskit's circuit metadata to jobs for Azure Quantum backends #278

Merged
merged 7 commits into from
Apr 15, 2022

Conversation

ricardo-espinoza
Copy link
Contributor

Running StateTomography from qiskit_experiments requires information from the circuit metadata that should be present in the job output. If those properties are not present, analysis of results will fail.

This change adds the corresponding circuit metadata.

Copy link
Member

@anpaz anpaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add/modify some test that checks for this?

@anpaz
Copy link
Member

anpaz commented Mar 26, 2022

This PR should address #259

@anpaz
Copy link
Member

anpaz commented Mar 26, 2022

This is also a fix for running VQE, mentioned in #224

@anpaz anpaz changed the title Propagate circuit metadata to Azure Quantum job for IonQ backend Propagate circuit metadata to Qiskit jobs for Azure Quantum backends Apr 14, 2022
Copy link
Member

@anpaz anpaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original changes only fixed IonQ backends. My latest push refactors the Qiskit backends to have a common base class that appends the metadata by default. It also removes a bunch of duplicated code.

@anpaz anpaz changed the title Propagate circuit metadata to Qiskit jobs for Azure Quantum backends Propagate Qiskit's circuit metadata to jobs for Azure Quantum backends Apr 14, 2022
@anpaz
Copy link
Member

anpaz commented Apr 14, 2022

The new common base Backend class addresses #263

@anpaz
Copy link
Member

anpaz commented Apr 14, 2022

addresses #258

@ricardo-espinoza ricardo-espinoza merged commit 9c7b473 into main Apr 15, 2022
@ricardo-espinoza ricardo-espinoza deleted the ricardoe/qdk-python-metadata-fix-to-main branch April 15, 2022 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants