-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qubit count update #635
qubit count update #635
Conversation
@ZachMassa LGTM, I think we also would need to update number of qubits for h2-1 here
|
updated quantinuum.py in backends so H2 returns 56 qubits.
Thank you for catching this. It should be updated now. |
Sorry, just found why the unit-tests are failing. We're also going to need to update this test:
it assumes that h2-1 uses 32 qubits
|
@ZachMassa, following up on this PR to see if you still wanted to merge this? I think there's the remaining failing unit test that @kikomiss pointed out, and then we can merge. |
I am fine with merging it. It seems like the issue mentioned above is that the unit test assumed H2 has a qubit count of 32 instead of 56. |
@ZachMassa , can you make the fix for the unit test, since these changes are on your fork? Otherwise, the pipelines won't pass in order for your PR to merge. |
@xinyi-joffre I believe that these tests should be updated to reflect the new qubit count now. |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
…chMassa/Microsoft-qdk-python into qubit-count-update-quantinuum
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
Thank you for the update, @ZachMassa ! It's been merged! |
Updating the H2-1 target to 52 qubits to match current performance specifications.