Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qubit count update #635

Merged
merged 7 commits into from
Oct 21, 2024

Conversation

ZachMassa
Copy link
Contributor

Updating the H2-1 target to 52 qubits to match current performance specifications.

@ZachMassa ZachMassa requested a review from a team as a code owner August 8, 2024 14:42
@kikomiss
Copy link
Contributor

kikomiss commented Aug 9, 2024

@ZachMassa LGTM, I think we also would need to update number of qubits for h2-1 here

updated quantinuum.py in backends so H2 returns 56 qubits.
@ZachMassa
Copy link
Contributor Author

@ZachMassa LGTM, I think we also would need to update number of qubits for h2-1 here

Thank you for catching this. It should be updated now.

@kikomiss
Copy link
Contributor

Sorry, just found why the unit-tests are failing. We're also going to need to update this test:

def test_configuration_quantinuum_backends(self):

it assumes that h2-1 uses 32 qubits

@xinyi-joffre
Copy link
Collaborator

@ZachMassa, following up on this PR to see if you still wanted to merge this? I think there's the remaining failing unit test that @kikomiss pointed out, and then we can merge.

@ZachMassa
Copy link
Contributor Author

@ZachMassa, following up on this PR to see if you still wanted to merge this? I think there's the remaining failing unit test that @kikomiss pointed out, and then we can merge.

I am fine with merging it. It seems like the issue mentioned above is that the unit test assumed H2 has a qubit count of 32 instead of 56.

@xinyi-joffre
Copy link
Collaborator

xinyi-joffre commented Oct 1, 2024

@ZachMassa , can you make the fix for the unit test, since these changes are on your fork? Otherwise, the pipelines won't pass in order for your PR to merge.

@ZachMassa
Copy link
Contributor Author

ZachMassa commented Oct 21, 2024

@ZachMassa , can you make the fix for the unit test, since these changes are on your fork? Otherwise, the pipelines won't pass in order for your PR to merge.

@xinyi-joffre I believe that these tests should be updated to reflect the new qubit count now.

@kikomiss
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@kikomiss
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@xinyi-joffre xinyi-joffre merged commit 508042c into microsoft:main Oct 21, 2024
7 checks passed
@xinyi-joffre
Copy link
Collaborator

Thank you for the update, @ZachMassa ! It's been merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants