-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use qsharp package to generate QIR #641
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idavis
force-pushed
the
iadavis/qsharp-qir-generation
branch
from
September 27, 2024 15:42
e40122c
to
0a3d926
Compare
kikomiss
approved these changes
Oct 1, 2024
kikomiss
approved these changes
Oct 2, 2024
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
idavis
force-pushed
the
iadavis/qsharp-qir-generation
branch
from
October 15, 2024 23:25
ec7f48a
to
02f4fe5
Compare
idavis
force-pushed
the
iadavis/qsharp-qir-generation
branch
from
October 21, 2024 22:24
02f4fe5
to
17cf9e8
Compare
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
kikomiss
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change replaces the usage of
qiskit-qir
with theqsharp
package. Of note:targetCapablities
is deprecated where possible and replaced withTargetProfile
. Sinceqsharp
is an optional dependency when not using Qiskit, the type is forward declared with astr
union option.target_profile
parameter is set to replacetargetCapablities
where possible.target_profile
for metadata.qsharp
QIR generation intrinsics. All changes to gateset are handled with decompositions with the exception ofbarrier
which is only sent for a single target. There had been changes to the QIR job submission gate sets that broke this behavior.azure/quantum/qiskit/backends/quantinuum.py
had the default profile/caps set to basic execution. This PR fixes the profile setting for this backend.qsharp
package can perform local resource estimation, the existing service submission is left intact with the new QIR generation code paths. PyQIR is used to implement output recording calls which are always part ofqsharp
code generation, but aren't handled by the service.qsharp
QIR generation correctly sets endianness of output recording to match Qiskit's semantics. This does mean that accessing data from jobs submitted with earlier versions will have incorrect result rendering.