Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update validation project with typing updates #434

Open
wants to merge 1 commit into
base: andrueastman/python38drop
Choose a base branch
from

Conversation

andrueastman
Copy link
Member

Updates generation of validation client with changes from microsoft/kiota#5974

Part of #433

Copy link

sonarqubecloud bot commented Jan 9, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
13.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@andrueastman andrueastman marked this pull request as ready for review January 9, 2025 08:21
@andrueastman andrueastman requested a review from a team as a code owner January 9, 2025 08:21
@@ -59,6 +60,9 @@ def serialize(self,writer: SerializationWriter) -> None:
"""
if writer is None:
raise TypeError("writer cannot be null.")
from .date_time_time_zone import DateTimeTimeZone
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why we're getting those local imports we don't seem to be doing anything with?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants