Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postChatImprovement #565

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

mithunjohny
Copy link
Contributor

Thank you for your contribution. Before submitting this PR, please include:

Id of the task, bug, story or other reference.

Description

Adding a performance improvement for post-chat loading: the postChatContext API in omnichannel-chat-sdk internally invokes getConversationDetails. Therefore, we can optimize by skipping the getConversationDetails call in endChat and directly using the postChatContext API instead.

Which will save 3 api calls from making to get the postchatContext

Solution Proposed

Detail what is the solution proposed, include links to design document if required or any other document required to support the solution

Acceptance criteria

Define what are the conditions to consider the PR has achieved the intended goal
image
image

Test cases and evidence

Include what tests cases were considered, any evidence of testing for future references, to identify any corner cases, etc

Sanity Tests

  • You have tested all changes in Popout mode
  • You have tested all changes in cross browsers i.e Edge, Chrome, Firefox, Safari and mobile devices(iOS and Android)
  • Your changes are included in the CHANGELOG

A11y

Please provide justification if any of the validations has been skipped.

@mithunjohny mithunjohny requested a review from a team as a code owner December 18, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant