Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: storvsp: new fuzzer #612

Merged
merged 3 commits into from
Jan 10, 2025
Merged

Conversation

mattkur
Copy link
Contributor

@mattkur mattkur commented Jan 6, 2025

First commit of a storvsp fuzzer. This begs, borrows, and steals from other test code to get something that compiles and runs.

Coverage shows that the fuzzer (at this point) does hit much of the core storvsp packet processing, except for the IO path. That remains a work in progress.

from other test code to get something that compiles and runs.

Coverage shows that the fuzzer (at this point) does hit much of the
core storvsp packet processing, _except_ for the IO path. That remains
a work in progress.
@mattkur mattkur requested review from a team as code owners January 6, 2025 18:25
Cargo.toml Outdated Show resolved Hide resolved
@smalis-msft
Copy link
Contributor

Overall this seems like a good starting point. Has this found anything interesting in its current state?

@mattkur
Copy link
Contributor Author

mattkur commented Jan 6, 2025

Overall this seems like a good starting point. Has this found anything interesting in its current state?

Thanks! And thanks for the feedback - for what it's worth, this is the biggest chunk of rust code I've written (so I'm appreciative and very open to any stylistic, idiomatic, and general feedback).

I was able to get the fuzzer to hang. It's not clear to me if this is a fuzzer bug or a bug in storvsp. I'm debugging. I've changed the fuzzer some since then, so I don't know if I'll be able to repro or not. I'll keep you posted.

* Don't promote as many things to `pub`, and make it explicit when that happens.
* .div_ceil rather than doing it manually
* Arbitrary fields in enums.
* cargo xtask fmt fix.
@mattkur
Copy link
Contributor Author

mattkur commented Jan 8, 2025

Overall this seems like a good starting point. Has this found anything interesting in its current state?

update: this found the issue fixed in #621 . That same test case now seems to hang. I'm going to hold off completing this until I get some more insight into that hang (or run out of time ...).

@mattkur mattkur merged commit 1bd3678 into microsoft:main Jan 10, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants