Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: a few more conversions to the proper casing of windows paths #586

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dgozman
Copy link
Contributor

@dgozman dgozman commented Jan 8, 2025

VSCode expects lowercase drive letter, while Playwright expects uppercase drive letter. This includes fixes from #584 and more.

To properly test this, updated vscode mock to match vscode proper, which revealed a few failing tests:

    [default] › global-errors.spec.ts:19:5 › should report duplicate test title ────────────────────
    [default] › list-tests.spec.ts:442:5 › should forget tests after error before first test ───────
    [default] › problems.spec.ts:55:5 › should update diagnostics on file change ───────────────────
    [default] › watch.spec.ts:24:5 › should watch all tests ────────────────────────────────────────
    [default] › watch.spec.ts:147:5 › should watch test file ───────────────────────────────────────
    [default] › watch.spec.ts:198:5 › should watch tests via helper ────────────────────────────────

Watch fails because it tries to watch lowercase paths in Playwright. Errors through diagnostics fail because they update with both lowercase and uppercase paths.

References microsoft/playwright#34146.
References microsoft/playwright#33671.

VSCode expects lowercase drive letter, while Playwright expects
uppercase drive letter. To properly test this, update vscode mock
to match vscode proper, which reveals a few failing tests:
- watch fails because it tries to watch lowercase paths in Playwright;
- errors through diagnostics fail because they update with both
  lowercase and uppercase paths.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant