feat: download browsers as TAR #34033
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
packages/playwright-core/src/server/registry/oopDownloadBrowserMain.ts
Outdated
Show resolved
Hide resolved
| @@ -10,6 +10,7 @@ | |||
| }, | |||
| "dependencies": { | |||
| "extract-zip": "2.0.1", | |||
| "tar-fs": "^3.0.6", | |||
There was a problem hiding this comment.
I understand the library is popular, but its deps list seem to be excessive for what it does a little. Did we consider alternatives?
There was a problem hiding this comment.
Oh wow, "tar" is even more...
There was a problem hiding this comment.
Yes, we considered tar-fs, tar and writing our own. Writing our own turned out more complex than imagined, because webkit has very long path names and the format becomes tricky when that's involved. Of the three, tar-fs seemed the most focused.
| @@ -48,8 +48,8 @@ | |||
| "revision": "1011", | |||
| "installByDefault": true, | |||
| "revisionOverrides": { | |||
| "mac12": "1010", | |||
| "mac12-arm64": "1010" | |||
| "mac12": "1011", | |||
There was a problem hiding this comment.
whats the motivation for changing this?
There was a problem hiding this comment.
1010 doesn't have .tar.br, and 1010 is identical to 1011 in functionality
This comment has been minimized.
This comment has been minimized.
| @@ -1229,6 +2813,6 @@ END OF [email protected] AND INFORMATION | |||
|
|
|||
| SUMMARY BEGIN HERE | |||
| ========================================= | |||
| Total Packages: 48 | |||
| Total Packages: 60 | |||
There was a problem hiding this comment.
We are paying a 25% bump in # of deps for a feature that does not link to a user report linked. Usually not a very good sign.
There was a problem hiding this comment.
True. It also increases the zip bundle size from 112kb to 202kb. We had this attempt of writing our own tar parser, maybe we should give it another try.
|
Just as an idea, can we utilize extract-zip's non-compression mode for tar? That way we use zip for tar and don't need all this extra code? i.e. the files will be .zip.br, not .tar.br. |
That'd save some dependencies, but would result in slightly larger bundles1 and it'd prevent streaming extraction. I'd prefer to stick with TAR, gonna take a stab at reducing the bundle size for that. Footnotes
|
|
Alright, i've vendored That way we're using a tried & tested tar parser, but don't pay the download price. Let me know if you like that approach, and where's the best place for a vendored module to live / any license specifics we need to follow. |
Test results for "tests 1"3 failed 6 flaky37513 passed, 654 skipped Merge workflow run. |
Some of our browsers are already available as
.tar.br. Compared to the current.ziparchives, the brotli tarballs are ~10-30% smaller. This PR makes us download brotli files for chromium and webkit.