Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(bidi): add missing canonical screenshots for tests running with Firefox and WebDriver BiDi #34257

Conversation

lutien
Copy link
Contributor

@lutien lutien commented Jan 8, 2025

Adding missing canonical screenshots for tests running with Firefox and WebDriver BiDi which should help to make some tests passing and show better errors for still failing tests.

Copy link
Contributor

github-actions bot commented Jan 8, 2025

Test results for "tests 1"

3 failed
❌ [installation tests] › tests/playwright-electron-should-work.spec.ts:21:5 › electron should work @package-installations-ubuntu-latest
❌ [installation tests] › tests/playwright-electron-should-work.spec.ts:31:5 › electron should work with special characters in path @package-installations-ubuntu-latest
❌ [installation tests] › tests/playwright-electron-should-work.spec.ts:44:5 › should work when wrapped inside @playwright/test and trace is enabled @package-installations-ubuntu-latest

4 flaky ⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:109:1 › should show tracing.group in the action list with location @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:1598:1 › should show a popover @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-set-input-files.spec.ts:205:3 › should upload multiple large files @webkit-ubuntu-22.04-node18

37544 passed, 649 skipped
✔️✔️✔️

Merge workflow run.

@lutien
Copy link
Contributor Author

lutien commented Jan 9, 2025

@microsoft-github-policy-service agree company="Mozilla"

@lutien lutien marked this pull request as ready for review January 9, 2025 08:48
@yury-s yury-s merged commit c465e21 into microsoft:main Jan 9, 2025
27 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants