Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: list installed browsers #34258

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: list installed browsers #34258

wants to merge 2 commits into from

Conversation

resslr
Copy link

@resslr resslr commented Jan 8, 2025

List Installed Browser Command to Solve #34183

CoPilot Generated Summary:

  • Add playwright ls command to list installed browsers in packages/playwright-core/src/cli/commands/ls.ts.
  • Add --list option to npx playwright install command in packages/playwright-core/src/cli/commands/install.ts.
  • Register the new ls command in the CLI program in packages/playwright-core/src/cli/program.ts.
  • Write tests for the playwright ls command in packages/playwright-core/src/cli/commands/ls.test.ts.
  • Add documentation for the new playwright ls command and --list option in docs/src/cli.md.
  • Update .github/actions/run-test/action.yml to use npx playwright install --with-deps --list to list installed browsers.

Add new commands to list installed browsers.

Solves microsoft#34183

* Add `playwright ls` command to list installed browsers in `packages/playwright-core/src/cli/commands/ls.ts`.
* Add `--list` option to `npx playwright install` command in `packages/playwright-core/src/cli/commands/install.ts`.
* Register the new `ls` command in the CLI program in `packages/playwright-core/src/cli/program.ts`.
* Write tests for the `playwright ls` command in `packages/playwright-core/src/cli/commands/ls.test.ts`.
* Add documentation for the new `playwright ls` command and `--list` option in `docs/src/cli.md`.
* Update `.github/actions/run-test/action.yml` to use `npx playwright install --with-deps --list` to list installed browsers.
@resslr resslr changed the title add: list installed browsers feat: list installed browsers Jan 8, 2025
@resslr
Copy link
Author

resslr commented Jan 8, 2025

@microsoft-github-policy-service agree

Copy link
Contributor

github-actions bot commented Jan 8, 2025

Test results for "tests 1"

1371 passed, 7 skipped
✔️✔️✔️

Merge workflow run.

Copy link
Member

@Skn0tt Skn0tt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR does much more than what the issue asked for. Could you remove everything except the --list parameter?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants