Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix copy/paste when Terminal Chat is open #18412

Open
wants to merge 1 commit into
base: feature/llm
Choose a base branch
from

Conversation

PankajBhojwani
Copy link
Contributor

Summary of the Pull Request

TerminalPage was handling the copy/paste actions even when TerminalChat was open, preventing the command from reaching the palette. This commit checks the visibility of the chat pane before handling these actions.

Validation Steps Performed

Paste/copy are handled appropriately if the chat is open.

PR Checklist

Copy link
Member

@carlos-zamora carlos-zamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious, why do we have to check if Terminal Chat is open and not for the Command Palette? Can't we do the same thing the Command Palette did (however that was; maybe it was with the [preview]key-down/-up handlers?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants