Fix downloading from File Shares and Blob Containers #1357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MicroFish91
changed the title
nturinski
approved these changes
Dec 9, 2024
nturinski
added a commit
that referenced
this pull request
Dec 10, 2024
* Fix downloading from File Shares and Blob Containers (#1357) * Fix downloads * Remove unused change * Install azcopy in build pipeline (#1358) * Add viewProperties model to get full data of storage account (#1359) * Update package lock (#1361) * Update package lock * Update version --------- Co-authored-by: Matthew Fisher <[email protected]> Co-authored-by: Alex Weininger <[email protected]>
nturinski
added a commit
that referenced
this pull request
Dec 10, 2024
* Fix downloading from File Shares and Blob Containers (#1357) * Fix downloads * Remove unused change * Install azcopy in build pipeline (#1358) * Add viewProperties model to get full data of storage account (#1359) * Changelog and NOTICE --------- Co-authored-by: Matthew Fisher <[email protected]> Co-authored-by: Alex Weininger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1349
Basically fixed the
resourceUriso that we reference the parent (File Share or Blob Container) URI which is what the old implementation expects to work properly.I tried downloading all combinations of the files/folders below and it is working again... if you can think of anything else to try let me know.