feat: scan kits from a folder #4191
Conversation
|
@std-microblock Thanks for your patience, we hope to assess this as soon as we can, but it may not be until after the holidays. Thank you for understanding. |
|
@std-microblock thank you so much for your contribution, we greatly appreciate it and your support! As a quick update, we plan to take this PR into our extension soon. As a side note, we plan to prioritize enhancements to CMake presets support moving forward (see issue: #4117). If there is a reason you prefer kits, we would love to know more in the issue I linked. |
| @@ -6,6 +6,7 @@ Features: | |||
|
|
|||
| - Add support for Presets v9, which enables more macro expansion for the `include` field. [#3946](https://github.com/microsoft/vscode-cmake-tools/issues/3946) | |||
| - Add support to configure default folder in workspace setting. [#1078](https://github.com/microsoft/vscode-cmake-tools/issues/1078) | |||
| - Add the scan kits from a folder option | |||
There was a problem hiding this comment.
Please put a link to this PR following the pattern from other entries.
| if (!dir || dir.length === 0) { | ||
| return false; | ||
| } | ||
| const dirPathWithDepth = async (folder: string, depth: number = 5) => { |
There was a problem hiding this comment.
Confirming my understanding, this is a recursive method adding ALL directories under the selected folder to the paths to search?
There was a problem hiding this comment.
Nah, It has a depth limit of 5.
| if (!dir || dir.length === 0) { | ||
| return false; | ||
| } | ||
| const dirPathWithDepth = async (folder: string, depth: number = 5) => { |
There was a problem hiding this comment.
I'm noticing that thsi code is duplicated in the kitsController.ts and the presetsController.ts. Please extract it into a method so that we share code. Likely the best place to put it is in the kitsController alongside scanForKits or in kit.ts.
| canSelectFiles: false, | ||
| canSelectFolders: true, | ||
| canSelectMany: false, | ||
| openLabel: localize('select.folder', 'Select Folder') |
There was a problem hiding this comment.
Also, I think it may be a good idea to ensure somewhere that it will also search recursively within the folder. Either here or in the popup that asks to either scan for kits or choose a specific folder.
| return localize('unspecified.let.cmake.guess', 'Unspecified (Let CMake guess what compilers and environment to use)'); | ||
| } | ||
| if (kit.name === SpecialKits.ScanSpecificDir) { | ||
| return localize('search.for.compilers.in.dir', 'Search for compilers in a specific directory'); |
There was a problem hiding this comment.
We should likely make note here or surface to the user that it will recursively search, if that's what you'd like to happen.
|
I'll look into the changes when I have spare time. |
The following changes are proposed:
The purpose of this change
Make the creation of kits easier.