Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak logLevel in esbuild.js examples #7903

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion api/extension-guides/web-extensions.md
Original file line number Diff line number Diff line change
Expand Up @@ -531,7 +531,7 @@ async function main() {
platform: 'browser',
outdir: 'dist/web',
external: ['vscode'],
logLevel: 'silent',
logLevel: 'warning',
// Node.js global to browser globalThis
define: {
global: 'globalThis',
Expand Down Expand Up @@ -597,6 +597,7 @@ const esbuildProblemMatcherPlugin = {
build.onEnd((result) => {
result.errors.forEach(({ text, location }) => {
console.error(`✘ [ERROR] ${text}`);
if (location == null) return;
console.error(` ${location.file}:${location.line}:${location.column}:`);
});
console.log('[watch] build finished');
Expand Down
3 changes: 2 additions & 1 deletion api/working-with-extensions/bundling-extension.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ async function main() {
platform: 'node',
outfile: 'dist/extension.js',
external: ['vscode'],
logLevel: 'silent',
logLevel: 'warning',
plugins: [
/* add to the end of plugins array */
esbuildProblemMatcherPlugin,
Expand All @@ -73,6 +73,7 @@ const esbuildProblemMatcherPlugin = {
build.onEnd((result) => {
result.errors.forEach(({ text, location }) => {
console.error(`✘ [ERROR] ${text}`);
if (location == null) return;
console.error(` ${location.file}:${location.line}:${location.column}:`);
});
console.log('[watch] build finished');
Expand Down