Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cosine SimilarityMetricType #49

Closed
wants to merge 1 commit into from
Closed

Add Cosine SimilarityMetricType #49

wants to merge 1 commit into from

Conversation

MarioMartinPlaza
Copy link

Add Cosine SimilarityMetricType

@weianweigan
Copy link
Collaborator

Thanks @MarioMartinPlaza .

Cosine Metrics

The Cosine Metrics is widely regarded as the standard method for measuring the distance between vectors, particularly in Large Language Models (LLMs). With the release of Milvus 2.3.0, cosine metrics are now natively supported. As a result, users no longer need to quantize vectors for IP (Inner Product) metrics.

@weianweigan
Copy link
Collaborator

Copy link
Collaborator

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that just adding the enum value isn't enough - support also needs to be added in the GetGrpcMetricType method. I think a test that shows this working would also be a good idea.

@weianweigan note that I've already done some work for 2.3 support in the 2.3 branch. I think it's probably a good idea to merge that branch into main, so that main represents the latest version. We should also plan to complete the 2.3 work and release a package soon.

Is this something you can work on?

@weianweigan
Copy link
Collaborator

@roji Thank you for the reminder. Let me take a look at this branch, and perhaps I can continue working on the 2.3 branch after the Spring Festival holiday.

@lofcz
Copy link

lofcz commented Feb 18, 2024

Glad to hear the needle is about to move forward with 2.3 support!

@yhmo
Copy link
Collaborator

yhmo commented Feb 26, 2024

Hi @roji, I have sent an invitation to you with the repo write access, please confirm. Thank you so much for updating this repo!

@roji
Copy link
Collaborator

roji commented Feb 26, 2024

Thanks @yhmo, received and accepted the invitation!

@roji
Copy link
Collaborator

roji commented Feb 28, 2024

@MarioMartinPlaza I rebased your commit, added the necessary implementation and testing and submitted as #63.

Can you please comment on #53 so I can assign you for credit?

@roji roji closed this Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants