[Go] support concurrent writing, fix concurrent bug, add some unit test #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/lgtm |
sunby
reviewed
Oct 20, 2023
go/storage/lock/lock_manager.go
Outdated
| @@ -9,10 +13,18 @@ type LockManager interface { | |||
| Release(version int64, success bool) error | |||
| } | |||
|
|
|||
| type EmptyLockManager struct{} | |||
| type EmptyLockManager struct { | |||
| lock sync.Mutex | |||
There was a problem hiding this comment.
Should not add a lock here. If your target is to test concrrent write, maybe it's better to write a memory lock manager.
loloxwg
force-pushed
the
manifest
branch
2 times, most recently
from
26af926 to
47efb83
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: loloxwg, sunby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.