Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix in filter search result is empty if pk type is varchar #39108

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

sunby
Copy link
Contributor

@sunby sunby commented Jan 9, 2025

Cherry pick from master
pr: #39016
#39107

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Jan 9, 2025
@mergify mergify bot added the dco-passed DCO check passed. label Jan 9, 2025
Copy link
Contributor

mergify bot commented Jan 9, 2025

@sunby Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

Copy link
Contributor

mergify bot commented Jan 9, 2025

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@czs007
Copy link
Collaborator

czs007 commented Jan 9, 2025

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, sunby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sunby
Copy link
Contributor Author

sunby commented Jan 9, 2025

/run-cpu-e2e

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.07%. Comparing base (4533fc8) to head (d692bb7).
Report is 20 commits behind head on 2.5.

Files with missing lines Patch % Lines
...rnal/core/src/segcore/ChunkedSegmentSealedImpl.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #39108      +/-   ##
==========================================
- Coverage   81.12%   81.07%   -0.06%     
==========================================
  Files        1383     1384       +1     
  Lines      195517   195595      +78     
==========================================
- Hits       158619   158569      -50     
- Misses      31355    31458     +103     
- Partials     5543     5568      +25     
Components Coverage Δ
Client 78.26% <ø> (ø)
Core 69.43% <0.00%> (-0.02%) ⬇️
Go 83.06% <ø> (-0.07%) ⬇️
Files with missing lines Coverage Δ
...rnal/core/src/segcore/ChunkedSegmentSealedImpl.cpp 22.81% <0.00%> (-0.11%) ⬇️

... and 59 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jan 9, 2025
@sre-ci-robot sre-ci-robot merged commit dad0d3b into milvus-io:2.5 Jan 9, 2025
17 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants