-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CDPS-1086: Dependency bumps and fixing subsequent issues #8
Conversation
99cfb20
to
d2465a9
Compare
d2465a9
to
a9dd012
Compare
) | ||
val foodAllergies: Nullish<List<String>> = getAttributeAsNullish<List<String>>(attributes, "foodAllergies") | ||
@field:NullishReferenceDataCodeList(domains = ["FOOD_ALLERGY"]) | ||
@JsonIgnore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jackson update changed the way that it was handling Nullish... which meant that I now needed to @JsonIgnore
these fields... which then has a knock on impact that the OpenAPI schema is then ignored... (annoyingly for us, there's no way of forcing OpenAPI to ignore an @JsonIgnore
https://github.com/springdoc/springdoc-openapi/blob/main/springdoc-openapi-starter-common/src/main/java/org/springdoc/core/utils/SpringDocAnnotationsUtils.java#L91).
@@ -19,7 +19,7 @@ import java.time.ZonedDateTime | |||
class FieldHistory( | |||
@Id | |||
@GeneratedValue(strategy = GenerationType.IDENTITY) | |||
val fieldHistoryId: Long = -1, | |||
val fieldHistoryId: Long = 0, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JPA changed how it was handling unpersisted entities... suddenly you're not allowed to have a default value of -1
anymore to identify something not persisted 🤷
@@ -84,7 +83,8 @@ class OpenApiConfiguration( | |||
val properties = schema.properties ?: mutableMapOf() | |||
for (propertyName in properties.keys) { | |||
val propertySchema = properties[propertyName]!! | |||
if (propertySchema is DateTimeSchema) { | |||
|
|||
if (propertySchema.format == "date-time") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OpenAPI changes also broke this, now having to check the format instead...
No description provided.