[ESWE-1181] Employer Creation; JB API client, retriever #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- implemented `JobsBoardApiClient`, with unit tests and integration tests - implemented `EmployerRetriever`, with integration tests
rickchoijd
commented
Jan 21, 2025
| @@ -0,0 +1,43 @@ | |||
| package uk.gov.justice.digital.hmpps.jobsboardintegrationapi.employers.domain | |||
|
|
|||
| object EmployerMother { | |||
There was a problem hiding this comment.
copied from jobs-board backend
There was a problem hiding this comment.
The naming and idea was taken from this pattern: https://martinfowler.com/bliki/ObjectMother.html
Thanks for asking @gbmojo
There was a problem hiding this comment.
Let's rename it later
Comment on lines
+1
to
+13
| <configuration> | ||
| <appender name="CONSOLE" class="ch.qos.logback.core.ConsoleAppender"> | ||
| <encoder> | ||
| <pattern>%d{HH:mm:ss.SSS} [%thread] %-5level %logger{36} -%kvp- %msg%n</pattern> | ||
| </encoder> | ||
| </appender> | ||
|
|
||
| <logger name="uk.gov.justice.digital.hmpps.jobsboardintegrationapi" level="DEBUG"/> | ||
|
|
||
| <root level="INFO"> | ||
| <appender-ref ref="CONSOLE"/> | ||
| </root> | ||
| </configuration> |
There was a problem hiding this comment.
logging config for unit test without Spring Test
Comment on lines
+37
to
+42
| hmpps-jobs-board-api: | ||
| provider: hmpps-auth | ||
| client-id: ${api.client.id} | ||
| client-secret: ${api.client.secret} | ||
| authorization-grant-type: client_credentials | ||
| scope: read |
There was a problem hiding this comment.
Client credentials will be required to consume internal API (1 per env)
We better revise endpoint-based roles at our backend.
gbmojo
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JobsBoardApiClient, with unit tests and integration testsEmployerRetriever, with integration tests