CVSL-1613 Storing prison number against licence version (#1525)

ministryofjustice · Feb 1, 2024 · 5e500c1 · 5e500c1
1 parent 4b58c1a
commit 5e500c1
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 3 deletions.
diff --git a/migrations/20240131160000_add-prison-number-to-licence-version.js b/migrations/20240131160000_add-prison-number-to-licence-version.js
@@ -0,0 +1,11 @@
+exports.up = async function up(knex) {
+  await knex.schema.alterTable('licence_versions', (table) => {
+    table.string('prison_number', 7).nullable()
+  })
+}
+
+exports.down = async function down(knex) {
+  await knex.schema.alterTable('licence_versions', (table) => {
+    table.dropColumn('prison_number')
+  })
+}
diff --git a/server/data/licenceClient.ts b/server/data/licenceClient.ts
@@ -140,8 +140,8 @@ export class LicenceClient {
 
   saveApprovedLicenceVersion(bookingId, template) {
     const query = {
-      text: `insert into licence_versions (booking_id, licence, version, vary_version, template)
-                    select booking_id, licence, version, vary_version, $1
+      text: `insert into licence_versions (prison_number, booking_id, licence, version, vary_version, template)
+                    select prison_number, booking_id, licence, version, vary_version, $1
                     from licences where booking_id = $2`,
       values: [template, bookingId],
     }

diff --git a/test/data/licenceClient.test.ts b/test/data/licenceClient.test.ts
@@ -204,7 +204,7 @@ describe('licenceClient', () => {
   describe('saveApprovedVersion', () => {
     test('should pass in the correct sql', async () => {
       const expectedVersionUpdate = 'insert into licence_versions'
-      const expectedSelect = 'select booking_id, licence, version, vary_version, $1'
+      const expectedSelect = 'select prison_number, booking_id, licence, version, vary_version, $1'
       const expectedWhere = 'where booking_id = $2'
 
       await licenceClient.saveApprovedLicenceVersion(BOOKING_ID, 'templateName')