Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(nix): update flakes #1100

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

anmonteiro
Copy link
Contributor

alternative to #1099 that fixes nix-ocaml/nix-overlays#1816

@anmonteiro anmonteiro force-pushed the anmonteiro/update-flakes branch from 96296b0 to df8bd79 Compare December 9, 2024 21:43
@art-w
Copy link
Contributor

art-w commented Dec 12, 2024

Thank you so much for looking into this! I'm afraid the libcurl.so linking error is still present:

$ nix develop --extra-experimental-features nix-command --extra-experimental-features flakes
arthur@host:~/ocaml-cohttp$ dune build
File "cohttp-curl-lwt/test/dune", line 2, characters 7-28:
2 |  (name cohttp_curl_lwt_tests)
           ^^^^^^^^^^^^^^^^^^^^^
/nix/store/bwkb907myixfzzykp21m9iczkhrq5pfy-binutils-2.43.1/bin/ld: /nix/store/ixq7chmml361204anwph16ll2njcf19d-curl-8.11.0/lib/libcurl.so: undefined reference to `SSL_get0_group_name@OPENSSL_3.2.0'
collect2: error: ld returned 1 exit status
File "caml_startup", line 1:
Error: Error during linking (exit code 1)

I'm not sure why your workflow run command nix build -L .#cohttp-curl-lwt fails on the cohttp-lwt-unix tests with "resolution failed: unknown scheme" but I suspect it hasn't pulled everything required by cohttp-lwt-unix, as it otherwise works in the nix develop shell: (if we explicitly avoid building cohttp-curl-lwt)

arthur@host:~/ocaml-cohttp$ dune runtest -p http,cohttp,cohttp-lwt,cohttp-lwt-unix
(...tests pass with no issue...)

@anmonteiro
Copy link
Contributor Author

@art-w yeah I thought it was an environment issue because of nix develop ... but clearly it isn't.

I'll try openssl things next when I get a moment.

@anmonteiro anmonteiro force-pushed the anmonteiro/update-flakes branch from 3fee26e to 3446fbe Compare December 14, 2024 05:16
@anmonteiro anmonteiro marked this pull request as ready for review December 14, 2024 05:16
@anmonteiro
Copy link
Contributor Author

@art-w i just got to the bottom of this and fixed it in nix-ocaml/nix-overlays#1824

@art-w
Copy link
Contributor

art-w commented Jan 9, 2025

Fantastic, thanks a ton it works great! @rgrinberg Would you have time to look at this? :) (the ocaml-ci errors are unrelated)

@rgrinberg rgrinberg merged commit f3abde6 into mirage:master Jan 9, 2025
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

libcurl.so: undefined reference to SSL_get0_group_name@OPENSSL_3.2.0
3 participants